Skip to content

[ABLD-174] Make buildifier work on Windows #41213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

[ABLD-174] Make buildifier work on Windows #41213

merged 1 commit into from
Oct 14, 2025

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Sep 24, 2025 •
edited
Loading

What does this PR do?

Applies 2 more patches that were submitted upstream:

Motivation

  1. buildifier macro: its implementation and Windows runner script template ignore excluded patterns as of today,
  2. buildifier_test macro: the Windows runner script template doesn't consider the bazel-provided manifest file.

Describe how you validated your changes

Local Windows VM (QEMU/virt-manager).

Additional Notes

bazel run //bazel/buildifier takes 2 minutes on Windows:

  1. they're spawning a nested powershell and then use a "manual" recursion from within, which could be optimized => later effort,
  2. as Tony mentioned at multiple occasions, we should only run buildifier on modified files => again, later effort.

@rdesgroppes rdesgroppes added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Sep 24, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Sep 24, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Sep 24, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1c8d5040-c289-462d-8b01-90ef4232d45e

Baseline: 3d175ee
Comparison: 9d45db3
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +13.76 [+11.99, +15.54] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +13.76 [+11.99, +15.54] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.66 [+0.59, +0.73] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.62 [+0.41, +0.82] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_delta memory utilization +0.29 [+0.14, +0.44] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.28 [+0.08, +0.47] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.06 [-0.07, +0.19] 1 Logs
➖ ddot_logs memory utilization +0.05 [-0.01, +0.12] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.01 [-0.58, +0.60] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.22, +0.20] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.02 [-0.15, +0.10] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.63, +0.58] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.03 [-0.64, +0.58] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.08 [-0.12, -0.03] 1 Logs
➖ ddot_metrics memory utilization -0.11 [-0.28, +0.06] 1 Logs
➖ quality_gate_idle memory utilization -0.13 [-0.16, -0.09] 1 Logs bounds checks dashboard
➖ file_tree memory utilization -0.19 [-0.23, -0.16] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.20 [-0.24, -0.16] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput -0.23 [-0.83, +0.37] 1 Logs
➖ otlp_ingest_logs memory utilization -0.38 [-0.51, -0.25] 1 Logs
➖ quality_gate_logs % cpu utilization -2.26 [-5.06, +0.54] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -2.57 [-3.00, -2.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Sep 24, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3d175ee

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${676.05}$$ < $${702.15}$$ $${-0.04}$$ $${164.96}$$ < $${177.79}$$
✅ agent_deb_amd64_fips $${0}$$ $${670.55}$$ < $${696.65}$$ $${-0}$$ $${164.21}$$ < $${176.53}$$
✅ agent_heroku_amd64 $${0}$$ $${336.47}$$ < $${340.18}$$ $${-0}$$ $${89.82}$$ < $${91.08}$$
✅ agent_msi $${0}$$ $${1012.52}$$ < $${1015.38}$$ $${+0.02}$$ $${149.14}$$ < $${150.78}$$
✅ agent_rpm_amd64 $${0}$$ $${676.04}$$ < $${702.14}$$ $${+0}$$ $${167.27}$$ < $${180.53}$$
✅ agent_rpm_amd64_fips $${0}$$ $${670.54}$$ < $${696.64}$$ $${-0.01}$$ $${165.86}$$ < $${178.79}$$
✅ agent_rpm_arm64 $${0}$$ $${665.47}$$ < $${686.31}$$ $${-0.03}$$ $${153.42}$$ < $${161.22}$$
✅ agent_rpm_arm64_fips $${0}$$ $${660.99}$$ < $${681.84}$$ $${-0.02}$$ $${153.1}$$ < $${160.18}$$
✅ agent_suse_amd64 $${0}$$ $${676.04}$$ < $${702.14}$$ $${+0}$$ $${167.27}$$ < $${180.53}$$
✅ agent_suse_amd64_fips $${0}$$ $${670.54}$$ < $${696.64}$$ $${-0.01}$$ $${165.86}$$ < $${178.79}$$
✅ agent_suse_arm64 $${0}$$ $${665.47}$$ < $${686.31}$$ $${-0.03}$$ $${153.42}$$ < $${161.22}$$
✅ agent_suse_arm64_fips $${0}$$ $${660.99}$$ < $${681.84}$$ $${-0.02}$$ $${153.1}$$ < $${160.18}$$
✅ docker_agent_amd64 $${+0}$$ $${747.48}$$ < $${773.59}$$ $${-0}$$ $${252.3}$$ < $${266.06}$$
✅ docker_agent_arm64 $${-0}$$ $${760.86}$$ < $${781.7}$$ $${-0}$$ $${242.92}$$ < $${251.85}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${938.34}$$ < $${964.45}$$ $${-0}$$ $${320.93}$$ < $${334.68}$$
✅ docker_agent_jmx_arm64 $${-0}$$ $${940.33}$$ < $${961.17}$$ $${-0}$$ $${307.51}$$ < $${316.44}$$
✅ docker_cluster_agent_amd64 $${0}$$ $${212.96}$$ < $${213.74}$$ $${-0}$$ $${72.24}$$ < $${73.14}$$
✅ docker_cluster_agent_arm64 $${+0}$$ $${228.86}$$ < $${229.68}$$ $${+0}$$ $${68.51}$$ < $${69.41}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${38.41}$$ < $${39.3}$$ $${-0}$$ $${14.83}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.06}$$ < $${37.94}$$ $${-0}$$ $${14.28}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${+0}$$ $${7.81}$$ < $${8.75}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${28.22}$$ < $${29.11}$$ $${-0}$$ $${6.77}$$ < $${7.71}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.76}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.76}$$
✅ iot_agent_deb_amd64 $${0}$$ $${51.42}$$ < $${54.97}$$ $${+0}$$ $${12.98}$$ < $${14.45}$$
✅ iot_agent_deb_arm64 $${0}$$ $${48.81}$$ < $${51.9}$$ $${+0}$$ $${11.28}$$ < $${12.63}$$
✅ iot_agent_deb_armhf $${0}$$ $${48.39}$$ < $${51.84}$$ $${-0}$$ $${11.26}$$ < $${12.74}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${51.42}$$ < $${54.97}$$ $${+0}$$ $${13.0}$$ < $${14.47}$$
✅ iot_agent_suse_amd64 $${0}$$ $${51.42}$$ < $${54.97}$$ $${+0}$$ $${13.0}$$ < $${14.47}$$

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/tweak-bazel-windows-settings branch 5 times, most recently from ce938a4 to 0a469c7 Compare September 25, 2025 15:20
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Sep 25, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/tweak-bazel-windows-settings branch 5 times, most recently from f423559 to 85c3e9e Compare September 26, 2025 11:25
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Sep 26, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/tweak-bazel-windows-settings branch 2 times, most recently from 9f78461 to 970a959 Compare September 26, 2025 12:28
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Sep 26, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/tweak-bazel-windows-settings branch 2 times, most recently from ad3de9c to 0260422 Compare September 26, 2025 15:51
@rdesgroppes rdesgroppes mentioned this pull request Sep 29, 2025
Merged
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/tweak-bazel-windows-settings branch 3 times, most recently from bc85124 to 0b06c80 Compare October 14, 2025 10:37
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/tweak-bazel-windows-settings branch from 0b06c80 to 9d45db3 Compare October 14, 2025 11:42
@rdesgroppes rdesgroppes changed the title [WIP] Tweak bazel settings on Windows [ABLD-174] Make buildifier work on Windows Oct 14, 2025
@rdesgroppes rdesgroppes marked this pull request as ready for review October 14, 2025 12:38
@rdesgroppes rdesgroppes requested a review from a team as a code owner October 14, 2025 12:38
@rdesgroppes rdesgroppes added the ask-review Ask required teams to review this PR label Oct 14, 2025
@rdesgroppes rdesgroppes merged commit 2790e70 into main Oct 14, 2025
256 checks passed
@rdesgroppes rdesgroppes deleted the regis.desgroppes/tweak-bazel-windows-settings branch October 14, 2025 13:08
@github-actions github-actions bot added this to the 7.73.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alopezz alopezz alopezz approved these changes

Assignees

No one assigned

Labels

ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation

Projects

None yet

Milestone

7.73.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rdesgroppes @alopezz